There are a lot of good spinnerbaits out there right now. For me, a good spinnerbait should perform the duty it is meant to do. For example, if you have a spinnerbait mean for burning then it should do that well. That means it should be able to handle high speeds without rolling over or leaning heavily to one side.
If it is a slow rolling model, then the blade should spin at very slow speeds without causing much lift. I should be able to crank that lure at least 10 times or more before having to pause slightly for the bait to get back down. An "all-purpose" type bait should be stable at moderate speeds and the blades should spin at relatively slow speeds.
Good components, and doing its intended job is what makes a spinnerbait good. If it does all of those things and if used in the correct situation, a good spinnerbait will always catch fish.